First page Back Continue Last page Overview Graphics
How does the new image review work?
The new ProdNG image is not checked in perforce file by file. We get a full image in tar.gz format that is handed off to our pusher.
Reviews are done by having a script unpack 2 image tars, and generate reviewable reports for it:
- file changes (similar ls -alR type output)
- which packages got added/removed/updated
- changelog diffs for upgraded packages
- All ASCII files are checked into perforce simply so that we can track their changes with perforce review tools.
- compressed ASCII files (like man pages or docs) are uncompressed to allow for easy reviews.
- Other binary files can be processed by a plugin that turns them into reviewable ASCII.